Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concerns about CKEditor as dependency #39

Open
rsxm opened this issue Oct 7, 2023 · 1 comment
Open

Concerns about CKEditor as dependency #39

rsxm opened this issue Oct 7, 2023 · 1 comment

Comments

@rsxm
Copy link

rsxm commented Oct 7, 2023

Hi @matthiask , I've been a long-time follower of your work and share many of your development philosophies, so thanks for all your contributions! I'm investigating Feincms3 for a new project at our company (we already rely on django-tree-queries), but the legal team raised some concerns about the inclusion of CKEditor4. They flagged both that it is end of life status as well as the GPL/LPGL/MPL licensing.

Would you accept pull requests to move the CKeditor related code to its own repo as optional dependency for feincms3 and/or replace it with another editor? Maybe something like Trix](https://trix-editor.org/) aligns well with the philosophy in django-content-editor?

@matthiask
Copy link
Member

Hi @rsxm

Thanks for the nice words & you're welcome! Great to hear that the work is useful.

Re. CKEditor: Yes, I think that is doable. Maybe we could even go back to depending on django-ckeditor for the moment, since django-ckeditor will probably stay with the CKEditor 4 OSS version for the foreseeable future. I don't know...

I have been searching for alternative editors in the last few weeks; the advantage of CKEditor, TinyMCE and suchlikes is their ecosystem and the availability of plugins, but yeah -- we don't use them for most sites. An editor which only supports a more restricted set of features would be nicer, e.g. the mentioned Trix or also something custom built using ProseMirror (I have much and practically only good experiences with PM, but the learning curve is extremely steep). A thing we often use besides the default headings (h1 to h4), bold, italic, sup, sub etc. is to add custom classes to a paragraph or to a span -- I don't like it much but it's a requirement. I don't know if Trix supports something like that?

For forward and backward compatibility it would probably be preferrable to maybe remove the rich text plugin altogether from feincms3 and only offer variants in separate packages (if licensing is a potential issue), e.g. feincms3-ckeditor, feincms3-trix-editor etc.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants