GitHub login does not work with OAuth clients created in organisations

[almereyda]

When creating an OAuth2 client on

• https://github.com/organizations/federated-wiki/settings/applications/

and providing its credentials to a wikiDomain, clicking the GitHub login in the popup window redirects it to https://github.com/login/oauth/authorize?response_type=code&scope=user%3Aemail&client_id=af698a7850beab68841 (this particular client ID has been derigistered) and shows the GitHub 404 page.

This does not happen when providing credentials to an OAuth2 client created on

• https://github.com/settings/developers

[almereyda]

@paul90 I have increased your privilege on @federated-wiki to Owner, so you can verify this, if you like. The regression would also happen with clients created in:

• https://github.com/organizations/fedwiki/settings/applications/

I guess.

[paul90]

I will try and look at this in the next day or two (Monday or Tuesday).

The docs say it works with both personal and organization accounts, so seems unexpected that you are having problems. GitHub Docs page.

[almereyda]

Yes, that was very unexpected.

[paul90]

Just tested, the location of things in GitHub has changed since the original notes were written. OAuth Apps is now under Developer settings in the side panel. There are also a few other changes, like creation of the app not showing an initial client secret, and having to generated a new client secret.

But using the oAuth app creating on the github org works. I have left the test application in OAuth Apps, feel free to delete, and to revert my increased privileges.

[almereyda]

Thanks for bringing counter evidence. I will check this in return, and decrease your privilege then.