Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript error on floating-ui >= 1.6.0 #15

Open
Cluster2a opened this issue Feb 5, 2024 · 1 comment
Open

TypeScript error on floating-ui >= 1.6.0 #15

Cluster2a opened this issue Feb 5, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Cluster2a
Copy link

Hey, there seems to be a type mismatch, when upgrading dependencies to:

  • "@floating-ui/core": "1.6.0",
  • "@floating-ui/dom": "1.6.1",

https://github.com/fedorovvvv/svelte-floating-ui/blob/a1f7bee81ed60a2dcbe143dfc4b0cefd48cde22a/src/lib/index.ts#L40C13-L40C72

Argument of type 'ComputeConfig' is not assignable to parameter of type 'Partial<{ placement?: Placement; strategy?: Strategy; middleware?: (false | { name: string; options?: any; fn: (state: { platform: Platform; placement: Placement; ... 6 more ...; elements: Elements; }) => Promisable<...>; })[]; platform?: Platform; }>'.
  Types of property 'platform' are incompatible.

Are there any plans to bump the dependencies?

@stayradiated
Copy link

Looks like we need to change the import of ComputePositionConfig from @floating-ui/core to @floating-ui/dom.

@fedorovvvv fedorovvvv added bug Something isn't working help wanted Extra attention is needed labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants