From 2efd7a3bcbc4fc5c98c32ab809fccd8e42532ccf Mon Sep 17 00:00:00 2001 From: John Szwaronek Date: Mon, 29 Jan 2018 08:42:48 -0500 Subject: [PATCH] Remove dataloader ref & remove debugging .catch() in service --- TODO.md | 5 +++-- lib/index.js | 9 --------- package.json | 1 - 3 files changed, 3 insertions(+), 12 deletions(-) diff --git a/TODO.md b/TODO.md index 97be6f8..8216591 100755 --- a/TODO.md +++ b/TODO.md @@ -4,14 +4,15 @@ - deps: fields to also fetch when a field is specified. useful for calculated fields - Dataloaders - - serializeRecordKey & serializeDataLoaderKey should use feathers-plus-common/object/sortKeys + NO - serializeRecordKey & serializeDataLoaderKey should use feathers-plus-common/object/sortKeys + NO --> Let user handle this as we think object keys will be rarely used. - services - metadata to allow paths such as `a-b/c`. - allow paths that are not valid JS names - join-monster - - seems to have a bug. see test for findUsers. + - seems to have a bug. see test for findUsers. Something returns null instead of []. - Register pluggable middleware functions, like in Express, to run before and after GraphQL resolvers. Auth, permissions, filters, etc. - https://github.com/alekbarszczewski/graphql-add-middleware diff --git a/lib/index.js b/lib/index.js index 709e08f..065d3b4 100755 --- a/lib/index.js +++ b/lib/index.js @@ -82,15 +82,6 @@ class Service { errors, data: response.data // Return what GraphQL data is available. Likely contains 'null's. }); - }) - // todo Remove. ***************************************************** - .catch(err => { - /* eslint-disable */ - console.log('\n========== graphql adapter error catch'); - console.log(err); - console.log('==========\n'); - /* eslint-enable */ - throw err; }); } } diff --git a/package.json b/package.json index 2374fa6..f968807 100755 --- a/package.json +++ b/package.json @@ -52,7 +52,6 @@ "@feathers-plus/cache": "1.3.1", "@feathers-plus/common": "0.1.0", "@feathersjs/errors": "3.2.0", - "dataloader-align-results": "0.4.0", "debug": "3.1.0", "deepmerge": "1.5.2", "feathers-hooks-common": "3.7.3",