Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS-Check fails: Some systems do not come with OsName Property #645

Open
TuemmlerKelch opened this issue Nov 22, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working minor Incremental updates and enhancements for improved functionality without major changes.
Milestone

Comments

@TuemmlerKelch
Copy link
Collaborator

Operating System

Microsoft Windows Server 2019

Report Name

Microsoft Windows Server 2019

Benchmark and ID (OPTIONAL)

No response

What happened?

The check fails, as this is empty: (Get-ComputerInfo OsName).OsName

What did you expect?

This should have been recognized as Server 2019

Current Version?

I used the latest official release.

@TuemmlerKelch TuemmlerKelch added the bug Something isn't working label Nov 22, 2024
@TuemmlerKelch TuemmlerKelch added this to the 5.11 milestone Nov 22, 2024
@TuemmlerKelch
Copy link
Collaborator Author

TuemmlerKelch commented Nov 22, 2024

EDIT:
Instead of making it more complex, we will instead skip that check in case (Get-ComputerInfo OsName).OsName does not return anything.

Keeping old answer for unknown reason:
We need to find out the values of (Get-ComputerInfo).WindowsProductName
for

  • Windows 7
  • Windows 8
  • Windows 8.1
  • Windows 10
  • Windows 11
  • Windows Server 2012 R2
  • Windows Server 2016
  • Windows Server 2019
  • Windows Server 2022
  • Windows Server 2025

If (Get-ComputerInfo OsName).OsName is emtpy, we will use (Get-ComputerInfo).WindowsProductName as fallback.

BUT for Windows 11, for example this states Windows 10, thus the careful analysis requested above is absolutely necessary.

@TuemmlerKelch TuemmlerKelch added the minor Incremental updates and enhancements for improved functionality without major changes. label Nov 22, 2024
@TuemmlerKelch TuemmlerKelch modified the milestones: 5.11, 5.12 Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor Incremental updates and enhancements for improved functionality without major changes.
Projects
None yet
Development

No branches or pull requests

2 participants