Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for "allowtelemetry" #329

Closed
TuemmlerKelch opened this issue May 23, 2023 · 4 comments · Fixed by #437
Closed

Add check for "allowtelemetry" #329

TuemmlerKelch opened this issue May 23, 2023 · 4 comments · Fixed by #437
Assignees
@qngngyn
Labels
enhancement New feature or request
Milestone
5.7.0

Comments

@TuemmlerKelch
Copy link
Collaborator

The setting allowtelemetry can bei either set to 0, 1 or 2, with 0 being the "best" setting, as it basically turns off telemetry.
However, for Windows 10/11 Home and Professional editions, setting "0" will not work, the behavior will be like "1".

So for these SKUs, we should keep this in mind and if we have benchmarks that specifically require "0", the test should fail with an appropriate message text.
@TuemmlerKelch TuemmlerKelch added the enhancement New feature or request label May 23, 2023
@TuemmlerKelch TuemmlerKelch added this to the 5.7 milestone Jul 20, 2023
@qngngyn qngngyn self-assigned this Oct 9, 2023
@qngngyn
Copy link
Collaborator

qngngyn commented Oct 9, 2023 •
edited
Loading

@TuemmlerKelch
What does "SKU" stand for? Also, which benchmarks require "extra" attention?
Is it best to allow "1" to be considered compliant, and extract and give Extrawurst to the "Must-0s" or...
Is it best to allow "0" to be considered compliant, and extract and give Extrawurst the "Can-Only-Be-1s" like Windows 10/11 Home/Professional?

@qngngyn
Copy link
Collaborator

qngngyn commented Nov 3, 2023

Set Warning for 1 that Home/Prof cannot be "more compliant"

@qngngyn
Copy link
Collaborator

qngngyn commented Nov 6, 2023

Accidently pushed in #437 but should work

@TuemmlerKelch TuemmlerKelch linked a pull request Nov 6, 2023 that will close this issue
Ticket 350 #437
Merged
@TuemmlerKelch
Copy link
Collaborator Author

Solved with PullRequest #437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qngngyn qngngyn

Labels
enhancement New feature or request
Projects
None yet
Milestone
5.7.0
Development

Successfully merging a pull request may close this issue.

Ticket 350 fbprogmbh/Audit-Test-Automation
2 participants
@TuemmlerKelch @qngngyn