Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RepeatedTask.getListOfTaskChanges is not named consistently with other getListOf... methods #94

Open
jonrkarr opened this issue Feb 2, 2021 · 4 comments

Comments

@jonrkarr
Copy link
Contributor

jonrkarr commented Feb 2, 2021

All of the getListOf[x] methods have names which are consistent with the name of the associated SED attribute. One exception is RepeatedTask.getListOfTaskChanges (rather than RepeatedTask.getListOfChanges). For consistency, it would be helpful to rename this method. Since that would break code that depends on the old name, an alias could be added so that either getListOfTaskChanges or getListOfChanges could be used, with both functions returning the same value.

@luciansmith
Copy link
Collaborator

The same is true for the 'line' and 'marker' children of Style: libsedml refers to them in the functions as 'LineStyle' and 'MarkerStyle' instead of just 'line' and 'marker' which are the actual names of the elements.

@fbergmann
Copy link
Owner

@luciansmith that is because every sed-ml class allready has a getLine function, that would return the line number. Thus i could not create another getLine function for returning the line style. So we had issue #67 , cause initially only line was different, then to make those consistent also the marker and fill were renamed within the library.

@luciansmith
Copy link
Collaborator

Ah, that makes sense.

@fbergmann
Copy link
Owner

as to the original issue from @jonrkarr it is called listOfTaskChanges, as we already have a listOfChanges for the model changes ... so what is returned here is a list of constructs ... but getListOfSetValues sounded really odd to me. So unless you insist (and let me know what the name should be), I would rather leave it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants