Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special L1V4 version of libSEDML: update the default version to L1V4 #56

Open
agarny opened this issue Apr 3, 2019 · 5 comments
Open

Comments

@agarny
Copy link
Contributor

agarny commented Apr 3, 2019

Right now, if you create a new SED-ML document using the special L1V4 version of libSEDML, it will have a level/version of L1V3 while one would expect it to have a level/version of L1V4.

@fbergmann
Copy link
Owner

I actually consider it a drop in replacement for the current libSEDML library, As such I figured that the 'current' version (i.e: 3) would be the default. Since the code base will have to do something differently, based on what the software intends to write out, I expected to actively make the decision when creating the SED-ML document, by using the level / version constructor.

if that causes you any issues though, i dont' mind changing that default.

@nickerso
Copy link
Contributor

nickerso commented Apr 3, 2019

I think it makes sense to default to the 'current' version, but expect users to generally use the level/version constructor if they need a specific version to be used.

@agarny
Copy link
Contributor Author

agarny commented Apr 3, 2019

Ok, I guess that, at this stage, it makes sense to default to L1V3, but once L1V4 is officially out, I would expect libSEDML to default to L1V4.

@fbergmann
Copy link
Owner

I totally agree! ... i'll make a full release as soon as l1v4 is out.

again .. if it causes you issues, please let me know and i'll update the default.

@agarny
Copy link
Contributor Author

agarny commented Apr 3, 2019

Right now, I am explicitly asking libSEDML to create an L1V4 SED-ML document, so I should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants