Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root directories are getting bigger everyday #53

Closed
munim opened this issue Aug 29, 2022 · 2 comments
Closed

Root directories are getting bigger everyday #53

munim opened this issue Aug 29, 2022 · 2 comments

Comments

@munim
Copy link

munim commented Aug 29, 2022

Dear @fawazahmed0 ,

You have done a fantastic job with the project. As you can see the root directory is increasing everyday with the date. Is there any plan for a refactoring?

Suggestion could be:
/{year}/{month}/{day}/currencies/{from_currency}/{to_currency}.json
This is more manageable as directory structuring.

However the bigger challenge is to provide backward compatibility with current directory pattern to support currently by application! Possibly by a new API version?

What are you thoughts around this?

Best Regards.

@fawazahmed0
Copy link
Owner

Whenever I release the newer version of this api, I will definitely consider refactoring the directory structure. Thanks for you input

@fawazahmed0 fawazahmed0 transferred this issue from another repository Feb 29, 2024
@fawazahmed0
Copy link
Owner

currency-api has stopped working, Please read the migration guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants