Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate #1

Closed
8 of 10 tasks
fawazahmed0 opened this issue Feb 29, 2024 · 7 comments
Closed
8 of 10 tasks

Migrate #1

fawazahmed0 opened this issue Feb 29, 2024 · 7 comments

Comments

@fawazahmed0
Copy link
Owner

fawazahmed0 commented Feb 29, 2024

  • migrate all issues
  • create new repo for npm currency-api (update current readme to point to it)
  • check compressed tarball feasibility (7zip gzip) (415 too many files issue, also tried npm-registry-client )
  • support only one end point
  • make task list
  • migrate to npm & pages
  • create readme
  • warn users with steps to migrate ( in json & readme )
  • push curr-api files with commit history here (check first)
  • other cdn (caching issue, max 1 day) and Other options for cdn #42 (possibly esm.sh )
@fawazahmed0 fawazahmed0 transferred this issue from another repository Feb 29, 2024
@Advaith3600
Copy link

There is no /currencies/{currencyCode}/{currencyCode} endpoint in this new API, so please only use /currencies/{currencyCode}

Is this endpoint going to be added in the future?

@fawazahmed0
Copy link
Owner Author

It will not be added in future, because npm doesn't support too many files, it gives 415 too many files Error

@omnigenous
Copy link

@fawazahmed0 Could you please keep YYYY-MM-DD format?

@yangshun
Copy link

yangshun commented Mar 1, 2024

@fawazahmed0 Thanks for the quick actions in getting the API back up!

Just wanted to report that the new version API (e.g. https://cdn.jsdelivr.net/npm/@fawazahmed0/[email protected]/v1/currencies/usd.json) doesn't seem to work. It'd also be good to continue supporting the old date format YYYY-MM-DD, not sure why it has to be changed.

@fawazahmed0
Copy link
Owner Author

fawazahmed0 commented Mar 2, 2024

@yangshun Dates are available from 2024-03-02
This should work:
https://cdn.jsdelivr.net/npm/@fawazahmed0/[email protected]/v1/currencies/usd.json

@omnigenous , no its not possible, the dates has to follow semver pattern. You can use regex to convert , eg:

"2024-03-02".replaceAll('-','.').replace(/\.0+(\d+)/gi , ".$1")

@omnigenous
Copy link

I was using the API in my bash script :D

I guess I could do date -u +%Y.%-m.%-d

@fawazahmed0
Copy link
Owner Author

I have added YYYY-MM-DD support. please refer the readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants