Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search ordered by macrogenesis shows NaN for text in position hover #600

Open
gerritbruening opened this issue Oct 18, 2022 · 1 comment

Comments

@gerritbruening
Copy link
Contributor

When I search for https://dev.faustedition.net/search?q=Sehnen+AND+Gebein&order=genesis and hover over "Text", "NaN" appears. I presume that this means "Not a Number".
A user objects that this use of the expression is incorrect, since the context (a value that is undefined or unrepresentable) is lacking here.

@thvitt thvitt changed the title Reconsider NaN for macrogenetic position of Text in search result Search ordered by macrogenesis shows NaN for text in position hover Oct 19, 2022
@thvitt
Copy link
Member

thvitt commented Oct 19, 2022

This hover shows the actual value of the ordering criterion – for the macrogenesis view, this is the position in the global ordering, which doesn’t exist for the text.

The number is just there for debugging purposes, maybe we can remove it altogether

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants