Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show loading symbol when order is applied in search? #599

Open
gerritbruening opened this issue Oct 17, 2022 · 5 comments
Open

Show loading symbol when order is applied in search? #599

gerritbruening opened this issue Oct 17, 2022 · 5 comments

Comments

@gerritbruening
Copy link
Contributor

@thvitt, a user has noted that he had to wait quite a bit before the results appear when order is applied in search, e.g. https://faustedition.net/search?q=Sehnen+AND+Gebein&order=genesis.
I personally cannot confirm this, at least with good connectivity. Normal search results may need a second or so to appear, though.
Do you have any knowledge about the normal time (if there is one) needed to generate the result page?

@thvitt
Copy link
Member

thvitt commented Oct 17, 2022

Depends very much on the number of results. Large queries are slow.

@gerritbruening
Copy link
Contributor Author

OK, this helps. As the result is not large in this case, I suspect that there was a connectivity issue.

@gerritbruening
Copy link
Contributor Author

In the original search, a
grafik
appears until the result is generated. Would it be possible to make this appear also when an option is selected?
Problem is that nothing seems to happen when I search for https://faustedition.net/search?q=faust and then click on, say, "Makrogenese".

@gerritbruening gerritbruening changed the title Delay until search results appear when order is applied Show loading symbol when order is applied in search? Oct 18, 2022
@thvitt
Copy link
Member

thvitt commented Oct 19, 2022

The dev version shows an ellipsis in the corresponding tab’s badge when new results are incoming, maybe that’s enough feedback?

image

I don’t particularly like showing the large loading badge because it would meen needless preliminary removal of the search results.

@gerritbruening
Copy link
Contributor Author

Something happens (unlike in non-dev), so yes, that's enough!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants