Reject out-of-order ranges #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reject ranges where the start position ("from") comes after the end
position ("to"), when nonzero.
cceckman-at-fastly
added a commit
to fastly/js-compute-runtime
that referenced
this pull request
Jun 4, 2025
These are rejected in Go as of fastly/compute-sdk-go#165, and in Rust as of PR 5097 in that repository. This is a guest (SDK/runtime) change rather than a host change so as not to break users that may accidentallly rely on this "feature"; hopefully their next SDK upgrade will highlight the issue.
cceckman-at-fastly
added a commit
to fastly/js-compute-runtime
that referenced
this pull request
Jun 11, 2025
These are rejected in Go as of fastly/compute-sdk-go#165, and in Rust as of PR 5097 in that repository. This is a guest (SDK/runtime) change rather than a host change so as not to break users that may accidentallly rely on this "feature"; hopefully their next SDK upgrade will highlight the issue.
cceckman-at-fastly
added a commit
to fastly/js-compute-runtime
that referenced
this pull request
Jun 11, 2025
These are rejected in Go as of fastly/compute-sdk-go#165, and in Rust as of PR 5097 in that repository. This is a guest (SDK/runtime) change rather than a host change so as not to break users that may accidentallly rely on this "feature"; hopefully their next SDK upgrade will highlight the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reject ranges where the start position ("from") comes after the end position ("to").
These don't have a good definition of how they should behave; reject them.