Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: ignore push events for dependabot branches #56

Closed
2 tasks done
Uzlopak opened this issue Aug 8, 2022 · 6 comments
Closed
2 tasks done

proposal: ignore push events for dependabot branches #56

Uzlopak opened this issue Aug 8, 2022 · 6 comments
Assignees

Comments

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 8, 2022

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

When dependabot opens a PR to update a dependency, it runs the whole ci pipeline twice. Once by push and once by pull request event. We could actually save one ci run when we would ignore the dependabot branch in push events.

We could actually configure, that only push events into master, main and next result in a pipeline run.

@Fdawgs Fdawgs self-assigned this Aug 8, 2022
@Fdawgs
Copy link
Member

Fdawgs commented Aug 8, 2022

Will take a look.

Less CI runs would mean less resources/bandwidth wasted and less time waiting.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 8, 2022

Exactly. When we e.g. activated license-check it always run twice, clogging the github runners.

Thank you. :)

@Fdawgs
Copy link
Member

Fdawgs commented Aug 8, 2022

something like the following would solve this, not just for Dependabot PRs but for all PRs:

on:
  push:
    branches:
     - main
     - master
     - next
    paths-ignore:
      - 'docs/**'
      - '*.md'
  pull_request:
    paths-ignore:
      - 'docs/**'
      - '*.md'

Your recent PR to fastify-helmet ran it twice as well: fastify/fastify-helmet#195

This was referenced Apr 27, 2023
This was referenced Apr 28, 2023
@Eomm
Copy link
Member

Eomm commented Apr 28, 2023

@Fdawgs
Copy link
Member

Fdawgs commented Apr 28, 2023

@Fdawgs are you using https://github.com/Eomm/massive-wax?

No, just using a horrible shell script 😂

@Fdawgs
Copy link
Member

Fdawgs commented Apr 28, 2023

PR made to all Fastify repos to add this.

@Fdawgs Fdawgs closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants