test: migrate to node test runner #690
Conversation
|
No linked issues found. Please add the corresponding issues in the pull request description. |
simoneb
left a comment
simoneb
left a comment
There was a problem hiding this comment.
I'd take the chance to migrate to Node's mocks as well instead of sinon
Is it something I can do in another PR? |
.gitignore
Outdated
| .vscode | ||
| node_modules/ | ||
| .idea | ||
| .nyc_output |
There was a problem hiding this comment.
do we still need this exclusion?
test/mapUpdateType.test.js
Outdated
| t.equal(mapUpdateType('bad_input'), updateTypes.any) | ||
| t.equal(mapUpdateType(), updateTypes.any) | ||
| t.equal(mapUpdateType('any'), updateTypes.any) | ||
| t.assert.deepStrictEqual(mapUpdateType('major'), updateTypes.major) |
There was a problem hiding this comment.
do we need the deep part when comparing simple values?
I'm ok with this, sure 👌 |
2 participants
Checklist
npm run testandnpm run benchmarkand the Code of conduct