Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHES support #363

Closed
2 tasks done
frequ opened this issue Feb 8, 2023 · 4 comments · Fixed by #364 or #367
Closed
2 tasks done

Add GHES support #363

frequ opened this issue Feb 8, 2023 · 4 comments · Fixed by #364 or #367

Comments

@frequ
Copy link
Contributor

frequ commented Feb 8, 2023

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

Currently automerging dependabot PRs does not work in GitHub Enterprise Server environment.
You'll get error from dependabot/fetch-metadata@v1.

Warning: Dependabot's commit signature is not verified, refusing to proceed.
Error: PR is not from Dependabot, nothing to do.

I believe this could be easily solved just by passing skip-commit-verification to dependabot/fetch-metadata@v1 (https://github.com/dependabot/fetch-metadata) action.

I'd propose adding new input skip-commit-verification and then passing it to dependabot/fetch-metadata@v1.

Motivation

Support for GHES.

Example

steps:
  - name: Automerge GHES dependabot PR
    uses: fastify/github-action-merge-dependabot@v3
    with:
      skip-commit-verification: true
@simoneb
Copy link
Collaborator

simoneb commented Feb 8, 2023

Thanks for this! Unfortunately we don't have a GHES subscription so we can't easily test this. It seems like a fairly simple change, would you like to send a PR for this?

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

🎉 This issue has been resolved in version 3.6.0 🎉

The release is available on:

Your optic bot 📦🚀

@frequ frequ mentioned this issue Feb 10, 2023
4 tasks
@frequ
Copy link
Contributor Author

frequ commented Feb 10, 2023

Still not quite working – works for dependabot/fetch-metadata action now, but still not internally. Made a fix PR

@github-actions
Copy link

🎉 This issue has been resolved in version 3.6.1 🎉

The release is available on:

Your optic bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants