Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support openapi 3.0 for dynamic configuration #87

Closed
SkeLLLa opened this issue Jul 14, 2018 · 2 comments · Fixed by #333
Closed

Support openapi 3.0 for dynamic configuration #87

SkeLLLa opened this issue Jul 14, 2018 · 2 comments · Fixed by #333
Labels
good first issue Good for newcomers

Comments

@SkeLLLa
Copy link
Contributor

SkeLLLa commented Jul 14, 2018

Seems underlying module swagger-parser already supports new openapi v3 specifications. So I think it would be good if this module will support it as well.

The main idea just to make https://github.com/fastify/fastify-swagger/blob/master/dynamic.js#L59 configurable through options.

However it will also require to refactor some things like securityDefinitions, because in 3.0 they moved to other sections of config file.

I'm not sure that fastify schemas are compatible with openapi v3 specs.

@sjorsjes
Copy link

Does this include Bearer auth aswell? https://swagger.io/docs/specification/authentication/bearer-authentication/

@SkeLLLa
Copy link
Contributor Author

SkeLLLa commented Aug 21, 2018

@sjorsjes I've implemented this as separate module https://www.npmjs.com/package/fastify-oas. It's compatible with fastify-swagger and it should support bearer auth.

@Eomm Eomm self-assigned this Mar 14, 2019
@Eomm Eomm removed their assignment Sep 17, 2019
@Eomm Eomm added the good first issue Good for newcomers label Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants