-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uri-js from dependencies #127
Comments
As I said ibn the other issue: uri-js is a dev dependency. Why should it be resulting in a warning like that? |
I think the issue is in ajv, as it still uses uri-js and not our implementation. We dont need to change anything imho |
Lot of security scanners are considering dev-dependencies same as dependencies because some are used to transpile code. |
I think you might have some issue with configuring your security scanners, usually they don't pick up 3rd party devdependencies. |
Working with severals over the years; some are brain dead and don't allow this. As also some security teams don't even want to care about this neither. |
Would you consider https://www.npmjs.com/package/uri-js-replace as a replacement for compatible test? |
if it's maintained and doesn't have CVEs yes. |
Prerequisites
Issue
uri-js
is creating vulnerabilities issues in downstream repositories: ajv-validator/ajv#1978We use it to test feature parity. As this package has been abandoned what we can do is installing it in CI and test against it and not requiring it within the
package.json
The text was updated successfully, but these errors were encountered: