Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uri-js from dependencies #127

Open
2 tasks done
zekth opened this issue Feb 18, 2025 · 7 comments · May be fixed by #130
Open
2 tasks done

Remove uri-js from dependencies #127

zekth opened this issue Feb 18, 2025 · 7 comments · May be fixed by #130

Comments

@zekth
Copy link
Member

zekth commented Feb 18, 2025

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

uri-js is creating vulnerabilities issues in downstream repositories: ajv-validator/ajv#1978

We use it to test feature parity. As this package has been abandoned what we can do is installing it in CI and test against it and not requiring it within the package.json

@Uzlopak
Copy link
Contributor

Uzlopak commented Feb 18, 2025

As I said ibn the other issue: uri-js is a dev dependency. Why should it be resulting in a warning like that?

@Uzlopak
Copy link
Contributor

Uzlopak commented Feb 18, 2025

I think the issue is in ajv, as it still uses uri-js and not our implementation. We dont need to change anything imho

@zekth
Copy link
Member Author

zekth commented Feb 18, 2025

As I said ibn the other issue: uri-js is a dev dependency. Why should it be resulting in a warning like that?

Lot of security scanners are considering dev-dependencies same as dependencies because some are used to transpile code.

@mcollina
Copy link
Member

I think you might have some issue with configuring your security scanners, usually they don't pick up 3rd party devdependencies.

@zekth
Copy link
Member Author

zekth commented Feb 18, 2025

Working with severals over the years; some are brain dead and don't allow this. As also some security teams don't even want to care about this neither.

@climba03003
Copy link
Member

Would you consider https://www.npmjs.com/package/uri-js-replace as a replacement for compatible test?

@zekth
Copy link
Member Author

zekth commented Feb 19, 2025

if it's maintained and doesn't have CVEs yes.

@zekth zekth linked a pull request Mar 13, 2025 that will close this issue
4 tasks
@zekth zekth changed the title Remove uri-js from dependendcies Remove uri-js from dependencies Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants