Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

merge/collaborate with http2-proxy? #40

Open
ronag opened this issue Aug 10, 2020 · 5 comments
Open

merge/collaborate with http2-proxy? #40

ronag opened this issue Aug 10, 2020 · 5 comments

Comments

@ronag
Copy link

ronag commented Aug 10, 2020

I believe there is some overlap here between this library and https://github.com/nxtedition/node-http2-proxy and just wanted to give a ping and see if there is any potential to combine efforts?

I'm looking to spend some extra time with it or something corresponding at some point in order to support undici.

@ronag
Copy link
Author

ronag commented Aug 10, 2020

I noticed https://github.com/fastify/fastify-http-proxy doesn't use this library? That's a bit peculiar?

@mcollina
Copy link
Member

This library was originally forked from fastify-reply-from. The idea of this repo being here is to reconcile them but this has been proven difficult.

BTW, I'm +1 in having a single one of those :).

@jsmylnycky
Copy link

@ronag @mcollina Is this something you're both still interested in doing? I'd be very happy to help contribute, whether one of them is chosen as the "go forward" project, or starting a completely fresh repo for the common one.

@q0rban
Copy link
Contributor

q0rban commented Mar 28, 2022

I'd be interested in seeing some benchmarks between http2-proxy and fast-proxy. In my somewhat rudimentary testing, it seems that http2-proxy is about as performant as http-proxy, with fast-proxy being anywhere from 2x to 4x faster.

On the other hand, the nice thing about http2-proxy is that it supports http2 and websockets. Is that possible with fast-proxy?

@ChakshuGautam
Copy link

@q0rban can confirm this. I used the same benchmark http2-proxy uses.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants