Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ready ignore timeout #103

Closed
Eomm opened this issue Apr 10, 2020 · 3 comments
Closed

Ready ignore timeout #103

Eomm opened this issue Apr 10, 2020 · 3 comments

Comments

@Eomm
Copy link
Member

Eomm commented Apr 10, 2020

The ready queue doesn't apply the timeout parameter.

Is this wanted?

const boot = require('..')

const app = boot({ timeout: 1000 })

// ready with two parameter
app.ready(function (_, done) {
  console.log('ready called')
  setInterval(() => {}, 100)
  // done() // not call done
})

app.on('start', () => {
  // never called
  console.log('start')
})

app.start()
@Eomm Eomm mentioned this issue Apr 10, 2020
4 tasks
@mcollina
Copy link
Member

It looks like a bug :/.

@Eomm
Copy link
Member Author

Eomm commented Apr 10, 2020

I will work on it tomorrow 👍

@Eomm
Copy link
Member Author

Eomm commented May 24, 2020

Released in #105

@Eomm Eomm closed this as completed May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants