Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic 2 support - is_classvar #283

Closed
ashupednekar opened this issue Feb 6, 2024 · 1 comment · May be fixed by #284
Closed

Pydantic 2 support - is_classvar #283

ashupednekar opened this issue Feb 6, 2024 · 1 comment · May be fixed by #284
Labels
enhancement New feature or request

Comments

@ashupednekar
Copy link

Is your feature request related to a problem? Please describe.
I'm only trying to use the class based views from this library. In order to support pydantic 2

Describe the solution you'd like
I understand that there are other open PR's addressing pydantic 2 support.
Since I'm only trying to use cbv decorator for class based view, I would like the is_classvar issue to be fixed first, so that it can be used in conjunction with pydantic 2, while the rest of the fixes are being developed.

Describe alternatives you've considered
If this PR is not merged, I would continue to use a fork internally, till #276 is merged

Additional context
We're migrating from Django rest to fastapi... so class based views are a must for us. I'm building out essential functionalities from DRF, so that we can retain the structured and maintainable code base we already have

@yuval9313
Copy link
Collaborator

It is supposed to be fixed in version 0.6.0 following #291, Update if more help is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants