Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the purpose of parse_obj's second argument: "update"? #523

Open
8 tasks done
zmievsa opened this issue Jan 3, 2023 · 2 comments
Open
8 tasks done

What is the purpose of parse_obj's second argument: "update"? #523

zmievsa opened this issue Jan 3, 2023 · 2 comments
Labels
question Further information is requested

Comments

@zmievsa
Copy link

zmievsa commented Jan 3, 2023

First Check

  • I added a very descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the SQLModel documentation, with the integrated search.
  • I already searched in Google "How to X in SQLModel" and didn't find any information.
  • I already read and followed all the tutorial in the docs and didn't find an answer.
  • I already checked if it is not related to SQLModel but to Pydantic.
  • I already checked if it is not related to SQLModel but to SQLAlchemy.

Commit to Help

  • I commit to help with one of those options 👆

Example Code

SomeModel.parse_obj({"one": 2}, {"three": 4})

Description

SQLModel's parse_obj supports the update argument which is not supported by pydantic's BaseModel. However, I do not see it ever used in docs, github issues, or in source code.

Could someone explain why it was added? What was the actual use case? I understand what it does, but I don't understand why it does it.

Operating System

Linux, Windows, macOS, Other

Operating System Details

No response

SQLModel Version

0.0.8

Python Version

3.11

Additional Context

No response

@zmievsa zmievsa added the question Further information is requested label Jan 3, 2023
@antont
Copy link

antont commented Feb 18, 2023

I'm using it in from_orm when get some parameters to create a new object in an API call from a client, but then add more values to the DB type using some logic in my endpoint function.

So am doing this:
dbob = dbtype.from_orm(createob, update=additionalvals)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants