Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two definitions of conv imported in resnet.py #24

Open
mnslarcher opened this issue May 13, 2023 · 0 comments
Open

Two definitions of conv imported in resnet.py #24

mnslarcher opened this issue May 13, 2023 · 0 comments

Comments

@mnslarcher
Copy link

In resnet.py there are (more than) two import *:

from .conv import *
from .init import *

Both contain a conv def. It took me a moment to figure out where the one that was actually used was (given the name I would have said in conv), maybe it would be helpful a refactoring or to avoid the "import *"? I think this is a classic case where import * can lead to unexpected behavior, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant