Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Mentions violate Matrix 1.11 Spec #2009

Open
1 of 2 tasks
TjardL opened this issue Jan 29, 2025 · 2 comments
Open
1 of 2 tasks

User Mentions violate Matrix 1.11 Spec #2009

TjardL opened this issue Jan 29, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@TjardL
Copy link

TjardL commented Jan 29, 2025

Checklist

  • I could not find a solution in the documentation, the existing issues or discussions.
  • I already asked for help in the chat

In which Project did the bug appear?

Other

If you selected "Other" as Project, please enter in which project the bug occurred.

Own App based on matrix

On which platform did the bug appear?

Chrome

SDK Version

33

Describe the problem caused by this bug

When mentioning a user, the raw data is in the following format, which is conform to matrix specification 1.3
{
"type": "m.room.message",
"content": {
"body": "@[USER] asdas",
"format": "org.matrix.custom.html",
"formatted_body": "<a href="https://matrix.to/#/@username:matrix.org\">@[Tjard L] asdas",
"msgtype": "m.text"
},
[...]
}

However, in Matrix 1.11 , this is changed to the following schema:
{
"body": "Hello Alice!",
"msgtype": "m.text",
"format": "org.matrix.custom.html",
"formatted_body": "Hello Alice!",
"m.mentions": {
"user_ids": ["@alice:example.org"]
}
}

The "m.mentions" field is missing.

Steps To Reproduce

  1. Send message with a mention in e.g. Fluffy Chat Web Client
  2. Open Raw data of the event

Screenshots or Logs

No response

Security related

No response

@TjardL TjardL added the bug Something isn't working label Jan 29, 2025
@krille-chan
Copy link
Contributor

Where is this violating the spec? As far as I can see, sending the m.mention field is optional

@Johennes
Copy link

Johennes commented Feb 4, 2025

This is not technically a spec violation. However, the spec does recommend that clients always include m.mentions for backwards compatibility.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants