Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question][features request] finer icon size adjustment #281

Closed
Yasen6275 opened this issue Feb 27, 2023 · 3 comments
Closed

[question][features request] finer icon size adjustment #281

Yasen6275 opened this issue Feb 27, 2023 · 3 comments
Labels
improvement request Request for an improvement to an existing feature solved This issue has been solved

Comments

@Yasen6275
Copy link

Yasen6275 commented Feb 27, 2023

Not sure if it is posble, can we have more positions on icon size slider.

@falzonv falzonv added the feature request Request for a new feature or option label Mar 17, 2023
@falzonv
Copy link
Owner

falzonv commented Mar 17, 2023

Hello,

(Sorry for the late answer, I am quite busy these weeks.)

Not really, at least not in-between other positions which I guess is what you meant...

Initially this setting was added because when using the launcher on a tablet, icons looked very small (phone size). My first plan was to make a toggle "Normal / Large" but then I discovered that the launcher could also be used on a TV and thought that even bigger icons would be needed for that case.

So I ended up using a slider with 4 positions numbered from 3 to 6 where the position is multiplied by 12 to get the icon size in dpi (which are then converted in pixels according to device density):
=> Position 3 gives an icon of 36dp (not really useful, but it makes the slider look better when the default value is selected)
=> Position 4 gives an icon of 48dp (icon size in the Android stock launcher, and default value in Discreet Launcher)
=> Position 5 gives an icon of 60dp (looks better than the default size on a tablet)
=> Position 6 gives an icon of 72dp (alternative for even bigger screens)

This setting was not designed for ultra-customization but just for the launcher to be more usable on larger screens.
Maybe I should mention it in the setting caption, something like "Icon size (for tablets)" instead of just "Icon size"...

Best regards.

@Yasen6275
Copy link
Author

No need to apologise. I'm perfectly aware that you have very little time for this project and that is perfectly fine by me.

I'm sorry to hear your explanation, but it is what it is.:)
Take care

@falzonv falzonv added the won't do/fix (see closure comment) This will not be worked on label Apr 1, 2023
@falzonv falzonv added improvement request Request for an improvement to an existing feature and removed feature request Request for a new feature or option labels May 4, 2024
@falzonv falzonv reopened this Aug 24, 2024
@falzonv falzonv added solved (waiting publish) Issue solved, new release published soon and removed won't do/fix (see closure comment) This will not be worked on labels Aug 24, 2024
@falzonv
Copy link
Owner

falzonv commented Aug 24, 2024

For proper labeling, following new discussions in #326 this is being fixed in new release v7.6.0.
I will leave this ticket open until it is available on F-Droid (usually takes 4 to 8 days).

@falzonv falzonv added solved This issue has been solved and removed solved (waiting publish) Issue solved, new release published soon labels Sep 4, 2024
@falzonv falzonv closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement request Request for an improvement to an existing feature solved This issue has been solved
Projects
None yet
Development

No branches or pull requests

2 participants