Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate falcon.testing.httpnow() #2389

Open
vytas7 opened this issue Oct 24, 2024 · 4 comments
Open

Deprecate falcon.testing.httpnow() #2389

vytas7 opened this issue Oct 24, 2024 · 4 comments
Labels
good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! maintenance needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks!
Milestone

Comments

@vytas7
Copy link
Member

vytas7 commented Oct 24, 2024

Apparently this ancient alias has survived unnoticed from the very early iterations of the framework.

Wrap it in the @deprecated(...) decorator so that we don't miss it again.

Write that it will be removed in Falcon 5.0 in the deprecation message.

@vytas7 vytas7 added good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! maintenance labels Oct 24, 2024
@CaselIT CaselIT added this to the Version 4.x milestone Oct 24, 2024
@kyash99252
Copy link

kyash99252 commented Oct 28, 2024

Hello @vytas7 ! I’d love to work on this issue as a first-time contributor. Is that okay?

@CaselIT
Copy link
Member

CaselIT commented Oct 28, 2024

Sure! If you have any question feel free to ask it here!

@arthurprioli
Copy link

Hey guys, I know I'm not the contributor in this issue but I have a suggestion for y'all.
To solve this, do we just have to add in init on testing?

httpnow = deprecated('This method is deprecated and will be removed in Falcon 5.0.')( _util.http_now )

@vytas7
Copy link
Member Author

vytas7 commented Nov 6, 2024

Hi @arthurprioli, yes, but we also need to add a test asserting that a deprecation warning is emitted upon referencing this method.

We also need to check with @kyash99252, maybe there is a PR already on the way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! maintenance needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks!
Projects
None yet
Development

No branches or pull requests

4 participants