-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cell_phone_in_e164 returning super long phone number... #2047
Comments
It appears that Faker generates a phone number that, in format, could potentially be a valid (or possible) phone number. It doesn't mean it actually is. For instance, Faker generated (using the |
Also facing this issue, got |
I tend to think this library should be more dependable and only generate phone numbers that will get parsed as being valid. In other words, should be either completely valid or completed not valid (just a string of numbers even without a real country code bc what's the point to have correct country codes if it doesn't parse correctly?) |
Hey, folks. In an effort to lighten our load as maintainers and be able to serve you better in the future, the faker-ruby team is working on cleaning out the cobwebs in this repo by pruning the backlog. As there are few of us, there are a lot of items that will simply never earn our attention in a reasonable time frame, and rather than giving you an empty promise, we think it makes more sense to focus on more recent issues. That means, unfortunately, that we must close this issue. Don't take this the wrong way: our aim is not to diminish the effort people have made or dismiss problems that have been raised. If you feel that we should reopen this issue, then please let us know so that we can reprioritize it. Thanks! |
Hi guys, this issue is still relevant. |
Thanks for reporting the bug and for your patience. I took a quick look at the PhoneNumber generator and it looks like it hasn't been changed in a while. I can't say what the intention was when this generator was added but I'm planning on working on this next Friday. |
Thanks for your patience, everyone! Please take a look at the proposed changes to fix this bug here #2842 |
I'm getting
"+186813608500740"
as a result fromFaker::PhoneNumber.cell_phone_in_e164
I'm using the phonelib library to parse this number and it cannot extract any information from it.
It does not look like a valid phone number where I can parse and extra a country code from it.
Was this intended?
The text was updated successfully, but these errors were encountered: