Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detecting incorrect windows 7 as windows 10 #768

Open
MarianoFacundoArch opened this issue Nov 21, 2024 · 9 comments
Open

Detecting incorrect windows 7 as windows 10 #768

MarianoFacundoArch opened this issue Nov 21, 2024 · 9 comments

Comments

@MarianoFacundoArch
Copy link

Opening ua-parser-js official website as well, a windows 7 is detected as windows 10:

{
  "ua": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/109.0.0.0 Safari/537.36",
  "browser": {
    "name": "Chrome",
    "version": "109.0.5414.75",
    "major": "109"
  },
  "cpu": {
    "architecture": "amd64"
  },
  "device": {},
  "engine": {
    "name": "Blink",
    "version": "109.0.0.0"
  },
  "os": {
    "name": "Windows",
    "version": "10"
  }
}
@MarianoFacundoArch
Copy link
Author

Same problem with Windows 8.
However https://whatsmyos.com/ always detects all correctly...

@MarianoFacundoArch
Copy link
Author

For Windows 8, in ua-parser I get:

{
  "ua": "Mozilla/5.0 (Windows NT 6.2; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/109.0.0.0 Safari/537.36",
  "browser": {
    "name": "Chrome",
    "version": "109.0.5414.75",
    "major": "109"
  },
  "cpu": {
    "architecture": "amd64"
  },
  "device": {},
  "engine": {
    "name": "Blink",
    "version": "109.0.0.0"
  },
  "os": {
    "name": "Windows",
    "version": "10"
  }
}

So it always returns OS windows 10, which is not true.

@MarianoFacundoArch
Copy link
Author

@faisalman ?

@faisalman
Copy link
Owner

Hi @MarianoFacundoArch, Are you using the same browser for those tests? Because the detected results are the same.

@MarianoFacundoArch
Copy link
Author

What do you mean ?
Windows 8 is not detected correctly in us parser when using client hints

@faisalman
Copy link
Owner

faisalman commented Dec 18, 2024

Hi, sorry, I mean what browser do you use & version? would be helpful if you have more details of the browser that I can investigate

@MarianoFacundoArch
Copy link
Author

Hi Faisalman, of course its windows 7, same one in browserstack.
If you want give me an url of whatever you want me to enter and i give you all the details

@janbrasna
Copy link

FYI the list of platform tokens ("NT x.y" versions) is documented here: https://learn.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/compatibility/ms537503%28v=vs.85%29#platform-tokens

Version Name
Windows NT 10.0 Windows 10
Windows NT 6.3 Windows 8.1
Windows NT 6.2 Windows 8
Windows NT 6.1 Windows 7

so the first UA (W7) reports itself as Win10, the other UA nonetheless looks like W8 and should have been detected as such…

@janbrasna
Copy link

Trying some UAstrings in current demo, they report correctly:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants