Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideas on new tool features, code samples, or GUI improvements we can contribute #95

Open
jomandaman opened this issue May 14, 2024 · 1 comment

Comments

@jomandaman
Copy link

Hey @SeaOtocinclus, we are moving into the implementation planning phase and defining our contributions to the project.

In the other Github issue about Architecture Diagrams (which we've produced refined versions of), you mentioned this:

Originally posted by @SeaOtocinclus in #76 (comment)
Would you like to implement a new python code sample?

  • one interesting sample could be how to export VRS sound data to a WAV file (https://realpython.com/python-wav-files/)
    I.e we are lacking code example to show how to manipulate sound data with our API and such feature would be welcomed

We are going to look into that as a possible code sample, although I noticed you had done even some recent feature additions like VRS Image Mutations (https://github.com/facebookresearch/projectaria_tools/pull/86/files) and were wondering if there are any other features like that we could help with. In particular, working with the GUI and making the user experience more refined is something we're interested in too! But if you have any pointers on other work to look at, we would be extremely grateful and work to contribute back.

@jomandaman
Copy link
Author

I'm not sure why this task was closed and reopened last night, must've been a mistake. And it's fine if you guys are busy with other tasks, but trying to keep a public record of our work too so you guys can see what we're up to.

@xiaqingp I saw you were tagged most recently for this too, so just including you as reference. We submitted our first two assignments and received feedback from our professor we are allowed to share as long as done publicly. We can consolidate this information in the end to help improve documentation and diagrams, if you'd like.

G1 --> Our first submission and attempt at reverse engineering Project Aria tools and creating UML diagrams
G2 --> Our second assignment, breaking down Architecture Styles in the code. We mainly found MVC architecture.

We also have a working Draw.io diagram to detail our current Architectural Styles, Patterns, and Implementation Plans -->

I granted both of you access to these documents, but please let us know if you can't access. @SeaOtocinclus in particular we are looking at incorporating the Long Wav feature you mentioned, and some useful improvements to the UI to be more intuitive. Hope all sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant