From 394d1e96cee514078f661740cdeb8afc5977cabd Mon Sep 17 00:00:00 2001
From: Chris Twigg <cdtwigg@meta.com>
Date: Thu, 25 Sep 2025 22:08:32 -0700
Subject: [PATCH] Change save_gltf_from_skel_states to
 save_gltf_with_skel_states. (#569)

Summary:

"_from" in the new naming scheme is reserved for the source (e.g. bytes), since we use _with_motion, we should use _with_skel_state.

Reviewed By: jeongseok-meta

Differential Revision: D82411872
---
 pymomentum/geometry/geometry_pybind.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pymomentum/geometry/geometry_pybind.cpp b/pymomentum/geometry/geometry_pybind.cpp
index 15fc0c8f10..52aa6580da 100644
--- a/pymomentum/geometry/geometry_pybind.cpp
+++ b/pymomentum/geometry/geometry_pybind.cpp
@@ -246,7 +246,7 @@ PYBIND11_MODULE(geometry, m) {
   // - load_urdf(urdf_filename)
   // - load_urdf_from_bytes(urdf_bytes)
   // - save_gltf(path, character, fps, motion, offsets, markers)
-  // - save_gltf_from_skel_states(path, character, fps, skel_states,
+  // - save_gltf_with_skel_states(path, character, fps, skel_states,
   // joint_params, markers)
   // - save_fbx(path, character, fps, motion, offsets)
   // - save_fbx_with_joint_params(path, character, fps, joint_params)
@@ -890,7 +890,7 @@ support the proprietary momentum motion format for storing model parameters in G
           py::arg("markers") =
               std::optional<const std::vector<std::vector<momentum::Marker>>>{})
       .def_static(
-          "save_gltf_from_skel_states",
+          "save_gltf_with_skel_states",
           &saveGLTFCharacterToFileFromSkelStates,
           py::call_guard<py::gil_scoped_release>(),
           R"(Save a character to a gltf file.