Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plugin discovery #489

Closed
omry opened this issue Mar 10, 2020 · 1 comment
Closed

Improve plugin discovery #489

omry opened this issue Mar 10, 2020 · 1 comment

Comments

@omry
Copy link
Collaborator

omry commented Mar 10, 2020

Plugin discovery is discovering the same plugins multiple times, this cases them to be imported multiple times which results in slow startup (especially if the plugins are slow to import like some of the new plugins (Ax sweeper)).

The plugin discovery should only happen once, and cached results should be used subsequently.

This will involve converting the static hydra.core.plugins.Plugins class to a Singleton, which is an incompatible API change.

@omry
Copy link
Collaborator Author

omry commented Mar 11, 2020

done in #490

@omry omry closed this as completed Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant