Support for newer versions torchvision - get_image_size #8
Conversation
Private function _get_image_size was changed to public in torchvision v0.11. The use of torchvision v0.11 and above will result in the following error: pytorch/vision#4328
|
Hi @ds2268! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
ds2268
changed the title
Private function _get_image_size was changed to the public in torchvision v0.11.
torchvision v0.11 was released in October 2021, thus I think it would be good to have the VICRegL repository limited to v0.11 and above.
"The code has been developed for PyTorch version 1.7.1 and torchvision version 0.8.2, but should work with other versions just as well." -> The alternative would be to at least mention that there is a compatibility break in the more recent versions.
The use of torchvision v0.11 and above will result in the following error: pytorch/vision#4328