Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedsim Autoscale doesn't take multiple extra_args in the args #61

Open
meteorfox opened this issue Oct 1, 2024 · 1 comment
Open

Feedsim Autoscale doesn't take multiple extra_args in the args #61

meteorfox opened this issue Oct 1, 2024 · 1 comment
Assignees
@excelle08

Comments

@meteorfox
Copy link

"extra_args": "-q 280 -w 10 -d 30"

It seems only the first parameter -q is taken
@excelle08
Copy link
Contributor

This has been fixed in 3624bf8. To apply the fix, please pull the latest repo and either:

  1. Reinstall feedsim by ./benchpress_cli.py clean feedsim_autoscale && ./benchpress_cli.py install feedsim_autoscale
  2. Copy packages/feedsim/run.sh to benchmarks/feedsim/run.sh and copy packages/feedsim/third_party/src/scripts/search_qps.sh to benchmarks/feedsim/src/scripts/search_qps.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@excelle08 excelle08

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meteorfox @excelle08