diff --git a/velox/type/tz/TimeZoneDatabase.cpp b/velox/type/tz/TimeZoneDatabase.cpp index d6f2b71968f..9687e4d2002 100644 --- a/velox/type/tz/TimeZoneDatabase.cpp +++ b/velox/type/tz/TimeZoneDatabase.cpp @@ -2257,6 +2257,9 @@ const std::unordered_map& getTimeZoneDB() { {2228, "Europe/Saratov"}, {2229, "Asia/Qostanay"}, {2230, "America/Nuuk"}, + {2231, "Pacific/Kanton"}, + {2232, "Europe/Kyiv"}, + {2233, "America/Ciudad_Juarez"}, }; return tzDB; } diff --git a/velox/type/tz/gen_timezone_database.py b/velox/type/tz/gen_timezone_database.py index 609e2e289f1..2ba00f1f663 100755 --- a/velox/type/tz/gen_timezone_database.py +++ b/velox/type/tz/gen_timezone_database.py @@ -42,11 +42,12 @@ // > velox/type/tz/TimeZoneDatabase.cpp // // The zone-index.properties file should be the same one used in Presto, -// Available here : https://github.com/prestodb/presto/blob/master/presto-common/src/main/resources/com/facebook/presto/common/type/zone-index.properties. +// Available here : +// https://github.com/prestodb/presto/blob/master/presto-common/src/main/resources/com/facebook/presto/common/type/zone-index.properties. // @generated -#include #include +#include namespace facebook::velox::util { diff --git a/velox/type/tz/tests/TimeZoneMapTest.cpp b/velox/type/tz/tests/TimeZoneMapTest.cpp index 713585b0043..c5b89f6d696 100644 --- a/velox/type/tz/tests/TimeZoneMapTest.cpp +++ b/velox/type/tz/tests/TimeZoneMapTest.cpp @@ -24,10 +24,16 @@ namespace { TEST(TimeZoneMapTest, simple) { EXPECT_EQ("America/Los_Angeles", getTimeZoneName(1825)); EXPECT_EQ("Europe/Moscow", getTimeZoneName(2079)); + EXPECT_EQ("Pacific/Kanton", getTimeZoneName(2231)); + EXPECT_EQ("Europe/Kyiv", getTimeZoneName(2232)); + EXPECT_EQ("America/Ciudad_Juarez", getTimeZoneName(2233)); EXPECT_EQ("-00:01", getTimeZoneName(840)); EXPECT_EQ(1825, getTimeZoneID("America/Los_Angeles")); EXPECT_EQ(2079, getTimeZoneID("Europe/Moscow")); + EXPECT_EQ(2231, getTimeZoneID("Pacific/Kanton")); + EXPECT_EQ(2232, getTimeZoneID("Europe/Kyiv")); + EXPECT_EQ(2233, getTimeZoneID("America/Ciudad_Juarez")); EXPECT_EQ(840, getTimeZoneID("-00:01")); EXPECT_EQ(0, getTimeZoneID("+00:00")); }