From 6f52cdce22f89c178fa96e948636bfeb83856231 Mon Sep 17 00:00:00 2001 From: Christian Zentgraf Date: Fri, 20 Mar 2026 19:08:15 -0400 Subject: [PATCH] fix(build): IcebergParquetStatsCollector requires ParquetWriter Also cleaned up some of the headers where duplicate inclusion was made and moved some from the header file to the cpp file. --- velox/connectors/hive/iceberg/CMakeLists.txt | 4 ++++ .../connectors/hive/iceberg/IcebergParquetStatsCollector.cpp | 1 + velox/connectors/hive/iceberg/IcebergParquetStatsCollector.h | 2 -- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/velox/connectors/hive/iceberg/CMakeLists.txt b/velox/connectors/hive/iceberg/CMakeLists.txt index 6bb02cb3847..4d7093190ca 100644 --- a/velox/connectors/hive/iceberg/CMakeLists.txt +++ b/velox/connectors/hive/iceberg/CMakeLists.txt @@ -43,6 +43,10 @@ velox_link_libraries( Folly::folly ) +if(VELOX_ENABLE_PARQUET) + velox_link_libraries(velox_hive_iceberg_splitreader velox_dwio_arrow_parquet_writer) +endif() + if(${VELOX_BUILD_TESTING}) add_subdirectory(tests) endif() diff --git a/velox/connectors/hive/iceberg/IcebergParquetStatsCollector.cpp b/velox/connectors/hive/iceberg/IcebergParquetStatsCollector.cpp index 7f9994f5812..10b04574c0a 100644 --- a/velox/connectors/hive/iceberg/IcebergParquetStatsCollector.cpp +++ b/velox/connectors/hive/iceberg/IcebergParquetStatsCollector.cpp @@ -25,6 +25,7 @@ #include "velox/dwio/parquet/writer/Writer.h" #include "velox/dwio/parquet/writer/arrow/Metadata.h" #include "velox/dwio/parquet/writer/arrow/Statistics.h" +#include "velox/type/Type.h" namespace facebook::velox::connector::hive::iceberg { diff --git a/velox/connectors/hive/iceberg/IcebergParquetStatsCollector.h b/velox/connectors/hive/iceberg/IcebergParquetStatsCollector.h index 71db087b12a..cc442a48722 100644 --- a/velox/connectors/hive/iceberg/IcebergParquetStatsCollector.h +++ b/velox/connectors/hive/iceberg/IcebergParquetStatsCollector.h @@ -17,12 +17,10 @@ #include -#include "velox/connectors/hive/TableHandle.h" #include "velox/connectors/hive/iceberg/IcebergColumnHandle.h" #include "velox/connectors/hive/iceberg/IcebergDataFileStatistics.h" #include "velox/dwio/common/FileMetadata.h" #include "velox/dwio/parquet/ParquetFieldId.h" -#include "velox/type/Type.h" namespace facebook::velox::connector::hive::iceberg {