fix: Install utf8proc headers #15341
Open
+16
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
kou
force-pushed
the
install-utf8proc
branch
from
18f1bea to
bccc06b
Compare
Contributor
Author
|
@majetideepak Could you take a look at this? |
`velox/functions/lib/string/StringCore.h` includes it. So we need to install them. This also updates `velox/.gitattributes`. Don't ignore `CMakeLists.txt` from diff because `external/**/CMakeLists.txt` are written by us.
kou
force-pushed
the
install-utf8proc
branch
from
bccc06b to
236bd69
Compare
Contributor
Author
|
@assignUser Could you review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
velox/functions/lib/string/StringCore.hincludesutf8procImpl.h. So we need to install them.This also updates
velox/.gitattributes. Don't ignoreCMakeLists.txtfrom diff becauseexternal/**/CMakeLists.txtare written by us.