From a2340721cb14338701beb6626f721a017fcb2d6d Mon Sep 17 00:00:00 2001 From: mbkkt Date: Wed, 29 Oct 2025 22:03:56 +0100 Subject: [PATCH] fix: Use explicit cmake dependency for fastfloat instead of implicit from folly --- CMake/resolve_dependency_modules/folly/CMakeLists.txt | 4 ++-- CMakeLists.txt | 3 +++ velox/functions/prestosql/CMakeLists.txt | 1 + 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CMake/resolve_dependency_modules/folly/CMakeLists.txt b/CMake/resolve_dependency_modules/folly/CMakeLists.txt index 28af264cfaa..884193118de 100644 --- a/CMake/resolve_dependency_modules/folly/CMakeLists.txt +++ b/CMake/resolve_dependency_modules/folly/CMakeLists.txt @@ -14,8 +14,8 @@ project(Folly) cmake_minimum_required(VERSION 3.28) -velox_set_source(fastfloat) -velox_resolve_dependency(fastfloat CONFIG REQUIRED) +velox_set_source(FastFloat) +velox_resolve_dependency(FastFloat CONFIG REQUIRED) set(VELOX_FOLLY_BUILD_VERSION v2025.04.28.00) set( diff --git a/CMakeLists.txt b/CMakeLists.txt index 318d7aafe22..4793c49866d 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -618,6 +618,9 @@ endif() velox_set_source(simdjson) velox_resolve_dependency(simdjson 3.13.0) +velox_set_source(FastFloat) +velox_resolve_dependency(FastFloat) + velox_set_source(folly) velox_resolve_dependency(folly) diff --git a/velox/functions/prestosql/CMakeLists.txt b/velox/functions/prestosql/CMakeLists.txt index ffdea9258c0..9047f40bbb1 100644 --- a/velox/functions/prestosql/CMakeLists.txt +++ b/velox/functions/prestosql/CMakeLists.txt @@ -75,6 +75,7 @@ velox_link_libraries( velox_presto_types velox_functions_util Folly::folly + FastFloat::fast_float stemmer::stemmer )