Skip to content

Commit 18f1bea

Browse files
committed
fix: Install utf8proc headers
`velox/functions/lib/string/StringCore.h` includes it. So we need to install them. This also updates `velox/.gitattributes`. Don't ignore `CMakeLists.txt` from diff because `external/**/CMakeLists.txt` are written by us.
1 parent 8a5a520 commit 18f1bea

File tree

3 files changed

+16
-10
lines changed

3 files changed

+16
-10
lines changed

velox/.gitattributes

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,4 @@
11
external/** -diff -merge
22
external/** linguist-vendored=true
3-
external/date/* -diff -merge
4-
external/date/* linguist-vendored=true
5-
external/duckdb/** -diff -merge
6-
external/duckdb/** linguist-vendored=true
7-
external/duckdb/tpch/** -diff -merge
8-
external/duckdb/tpch/** linguist-vendored=true
9-
external/md5/* -diff -merge
10-
external/md5/* linguist-vendored=true
11-
external/utf8proc/* -diff -merge
12-
external/utf8proc/* linguist-vendored=true
3+
external/**/CMakeLists.txt diff merge
4+
external/**/CMakeLists.txt linguist-vendored=false

velox/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ add_subdirectory(external/date)
2626
add_subdirectory(external/tzdb)
2727
add_subdirectory(external/md5)
2828
add_subdirectory(external/hdfs)
29+
add_subdirectory(external/utf8proc)
2930
#
3031

3132
# examples depend on expression
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# Licensed under the Apache License, Version 2.0 (the "License");
2+
# you may not use this file except in compliance with the License.
3+
# You may obtain a copy of the License at
4+
#
5+
# http://www.apache.org/licenses/LICENSE-2.0
6+
#
7+
# Unless required by applicable law or agreed to in writing, software
8+
# distributed under the License is distributed on an "AS IS" BASIS,
9+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
10+
# See the License for the specific language governing permissions and
11+
# limitations under the License.
12+
13+
velox_install_library_headers()

0 commit comments

Comments
 (0)