Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax highlighting configuration guide. #806

Merged
merged 3 commits into from
Dec 7, 2016
Merged

Add syntax highlighting configuration guide. #806

merged 3 commits into from
Dec 7, 2016

Conversation

mareksuscak
Copy link
Contributor

@mareksuscak mareksuscak commented Sep 30, 2016

Need to update the link after we add proper documentation on the Babel's website.

@mareksuscak mareksuscak changed the title Add syntax highlighting configuration guide. WIP: Add syntax highlighting configuration guide. Sep 30, 2016
@fson
Copy link
Contributor

fson commented Oct 23, 2016

@mareksuscak Looks like this is still waiting for the additions to the Babel website. Is there an issue / pull request somewhere that tracks those changes?

@mareksuscak
Copy link
Contributor Author

@fson Yup.

#804
babel/website#930

@gaearon
Copy link
Contributor

gaearon commented Nov 20, 2016

What are waiting for at the moment? Where can people contribute?

@mareksuscak
Copy link
Contributor Author

@gaearon For babel docs. PR is linked in my last comment above.

@gaearon
Copy link
Contributor

gaearon commented Nov 22, 2016

I see a link to a Babel issue about reorganizing content, but not an actual PR. Are we waiting for somebody to create a PR addressing it?

@mareksuscak
Copy link
Contributor Author

Well, I'd do it myself but there doesn't seem to be a final decision on how to reorganize it so I guess that's why it's stuck. Syntax highlighting doesn't fit into any category ATM.

@gaearon
Copy link
Contributor

gaearon commented Nov 22, 2016

From what I saw in the issue it looked like @hzoo was waiting for somebody to make a PR first and then finalize instead of trying to decide beforehand.

@mareksuscak
Copy link
Contributor Author

mareksuscak commented Dec 6, 2016

Updated the link. I have reorganized the Babel's docs after discussing with Henry on slack. Need to add the Editors page content, still. I think I'll add Atom, Sublime and Visual Studio Code and we can ask the community to contribute other editors. What do you think?

I'm sorry it took so long.

UPDATE: Adding link to the PR: babel/website#1041

@mareksuscak mareksuscak changed the title WIP: Add syntax highlighting configuration guide. Add syntax highlighting configuration guide. Dec 6, 2016
@hzoo
Copy link

hzoo commented Dec 6, 2016

Merged babel/website#1041 - looks like https://twitter.com/left_pad/status/806217618705313792

@fson
Copy link
Contributor

fson commented Dec 7, 2016

Looks good to me!

@fson fson merged commit 9fd528c into facebook:master Dec 7, 2016
@gaearon gaearon mentioned this pull request Dec 8, 2016
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
* Add syntax highlighting configuration guide.

* Update link.
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
* Add syntax highlighting configuration guide.

* Update link.
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants