Resolve app paths from realpath of CWD, fix #637 #648
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes all paths returned from
resolveApp()
begin with therealpath
of the app root, resolving any symlinks etc.Note:
realpathSync
throws when its argument is a non-existing path, so this change only assumes thatprocess.cwd()
exists and does a plainresolve
from there.@guivho Can you try this in your newly created project?
npm install motiz88/create-react-app#resolve-symlink-cwd && npm start
(later you can donpm install react-scripts
to restore things to normal).