-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a reasonable config for autoprefixer (resolves #73) #345
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Why would we put that in a global file and not |
Yeah, this should be a part of Webpack configs. |
The original issue #73 mentions an issue with css-loader which could be fixed via a browser list file, but it also mentions an alternative fix, so maybe that one could be used here. (supplying an option to css-loader) |
We want to be explicit. It’s unclear which tool would read a file called We don’t really care about DRY here, we care about explicitness so you can see how everything in config ties together. |
I updated the PR, trying my best to follow your great advices. |
Thank you! |
No description provided.