Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with an error code when npm/yarn install fails #1224

Merged
merged 1 commit into from
Dec 10, 2016

Conversation

fson
Copy link
Contributor

@fson fson commented Dec 10, 2016

Previously create-react-app exited with 0 after an installation error.

Previously create-react-app exited with 0 after an installation error.
@gaearon gaearon added this to the 0.8.4 milestone Dec 10, 2016
Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please merge if Travis passes.

@fson fson merged commit 0990ce0 into facebook:master Dec 10, 2016
@fson fson deleted the exit-error-on-install-fail branch December 10, 2016 01:54
@gaearon gaearon mentioned this pull request Dec 11, 2016
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
Previously create-react-app exited with 0 after an installation error.
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
Previously create-react-app exited with 0 after an installation error.
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants