Clean up Yarn detection and install code #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the “‘yarn’ is not recognized as an internal or external command, ...” message on Windows * Simplify the detection code: just run `yarn --version` – if it succeeds use `yarn`, if it fails use `npm`.
gaearon
approved these changes
Dec 10, 2016
This was referenced Dec 11, 2016
Merged
alexdriaguine
pushed a commit
to alexdriaguine/create-react-app
that referenced
this pull request
Jan 23, 2017
* Remove the “‘yarn’ is not recognized as an internal or external command, ...” message on Windows * Simplify the detection code: just run `yarn --version` – if it succeeds use `yarn`, if it fails use `npm`.
randycoulman
pushed a commit
to CodingZeal/create-react-app
that referenced
this pull request
May 8, 2017
* Remove the “‘yarn’ is not recognized as an internal or external command, ...” message on Windows * Simplify the detection code: just run `yarn --version` – if it succeeds use `yarn`, if it fails use `npm`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'yarn' is not recognized as an internal or external command, ...message on Windows.yarn --version– if it succeeds useyarn, if it fails usenpm.--verboseoption to Yarn if given, Yarn supports it now.Tested on macOS and Windows 10.