Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instruct Jest to load native components from RNW instead of RN #1201

Merged
merged 1 commit into from
Dec 8, 2016
Merged

Instruct Jest to load native components from RNW instead of RN #1201

merged 1 commit into from
Dec 8, 2016

Conversation

remon-nashid
Copy link
Contributor

This small change fixes #1085. Basically it includes @gaearon's suggested fix.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

@remon-nashid remon-nashid mentioned this pull request Dec 8, 2016
Closed
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon merged commit adbc1a2 into facebook:master Dec 8, 2016
@gaearon
Copy link
Contributor

gaearon commented Dec 8, 2016

Thank you!

@gaearon gaearon mentioned this pull request Dec 8, 2016
Merged
@gaearon
Copy link
Contributor

gaearon commented Dec 8, 2016

Should be in 0.8.3.

alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
@remon-nashid @alexdriaguine
Instruct Jest to load native components from RNW instead of RN (faceb…
443c0c0 
…ook#1201)
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
@remon-nashid @randycoulman
Instruct Jest to load native components from RNW instead of RN (faceb…
cf698e5 
…ook#1201)
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests fail in a react-native-web app with __DEV__ is not defined
3 participants
@remon-nashid @facebook-github-bot @gaearon