Add missing namespace to folly::IOBuf container TOML #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required for CodeGen v2, which does not add "using namespace xxx" and uses fully qualified names instead.
Codecov Report
@@ Coverage Diff @@
## main #192 +/- ##
=======================================
Coverage 64.31% 64.31%
=======================================
Files 87 87
Lines 9429 9429
Branches 1553 1553
=======================================
Hits 6064 6064
Misses 2542 2542
Partials 823 823 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JakeHillion
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for CodeGen v2, which does not add "using namespace xxx" and uses fully qualified names instead.