Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NameGen: Handle containers with zero template params #178

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

ajor
Copy link
Contributor

@ajor ajor commented Jun 23, 2023

Previously we always deleted the last two characters and appended a >.

Old:

MyContaine>

New:

MyContainer

Previously we always deleted the last two characters and appended a `>`.

Old:
  MyContaine>

New:
  MyContainer
@ajor ajor force-pushed the container-zero-params branch from 7379275 to b7d9b14 Compare June 23, 2023 18:52
@ajor ajor marked this pull request as ready for review June 23, 2023 18:53
@ajor ajor merged commit b0ef913 into facebookexperimental:main Jun 26, 2023
@ajor ajor deleted the container-zero-params branch June 26, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants