Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests: Set up CI testing for TypeGraph #161

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

ajor
Copy link
Contributor

@ajor ajor commented Jun 6, 2023

CTest can't forward command line arguments to the test runner, so add the option to using an environment variable to enable features instead.

CMake issue tracking the feature that would have been needed:
https://gitlab.kitware.com/cmake/cmake/-/issues/20470

Tests which aren't passing yet have been disabled in CI.

@ajor ajor force-pushed the type-graph-ci branch 2 times, most recently from ffede70 to 1c62009 Compare June 6, 2023 10:46
@ajor ajor force-pushed the type-graph-ci branch 5 times, most recently from 63f3e8a to a7d1487 Compare June 6, 2023 13:25
@ajor
Copy link
Contributor Author

ajor commented Jun 20, 2023

#172 should fix the CI failures we're seeing from bad DWARF here.

@ajor ajor force-pushed the type-graph-ci branch 4 times, most recently from dae99f9 to 1bc43b6 Compare June 27, 2023 13:08
@ajor ajor marked this pull request as ready for review June 27, 2023 13:09
test/integration/runner_common.cpp Outdated Show resolved Hide resolved
test/integration/runner_common.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@JakeHillion JakeHillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

CTest can't forward command line arguments to the test runner, so add
the option to using an environment variable to enable features instead.

CMake issue tracking the feature that would have been needed:
  https://gitlab.kitware.com/cmake/cmake/-/issues/20470

Tests which aren't passing yet have been disabled in CI.
@ajor ajor merged commit 4dc9007 into facebookexperimental:main Jun 27, 2023
@ajor ajor deleted the type-graph-ci branch June 27, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants