Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

RFP: cpu profiling through /prof-cpu-on #37

Open
rrh opened this issue May 1, 2015 · 1 comment
Open

RFP: cpu profiling through /prof-cpu-on #37

rrh opened this issue May 1, 2015 · 1 comment

Comments

@rrh
Copy link
Contributor

rrh commented May 1, 2015

I'm using the convenient oss-performance driver script to run real frameworks.

I want to be able to run the HHVM under test (UUT) compiled with GOOGLE_CPU_PROFILER. I currently set the env variable CPUPROFILE to name the file to dump profile info to when the UUT exit's cleanly, but if I happen to run the oss-performance driver script itself with a HHVM that was also compiled for google performance, then the CPUPROFILE env var will control both invocations of HHVM, and chaos ensues in regards to which HHVM really wrote the file named by CPUPROFILE.

Perhaps the oss-performance driver script could, under yet another flag, probe for the admin server requests /prof-cpu-on and /prof-cpu-off and if present, then have the admin server on the UUT turn on/off the profiler itself, and then the obnoxious CPUPROFILE env var wouldn't be needed.

Yeah, creeping featurism

@fredemmott
Copy link
Contributor

How about the existing setup and teardown script options?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants