Fix attachments code

[jnwarp]

When downloading an attachment, the byte length of the file is appended, see issue #617.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[gsingh93]

Thanks! What's actually happening here is that readfile is writing to the output buffer directly and the return value is the number of bytes read, which is being stored into $data. $data then gets sent down in the base class (DataController). While readfile is the more efficient way to do things, I think file_get_contents is cleaner in this case.