Fixed Login Form JS Bug (Fixes: #521) (#523)

* Login form JavaScript now properly retrieves and renders errors when invalid login credentials are provided.

* Added teamLoginFormError() distinguished from teamNameFormError() and teamTokenFormError().

* Updated teamPasswordFormError() to read the login AJAX response and call the appropriate error function.

* This PR fixes the bug identified in Issue #521.

Author: justinwray

src/static/js/index.js

@@ -7,6 +7,13 @@ function teamNameFormError() {
   });
 }
 
+function teamLoginFormError() {
+  $('.el--text')[0].classList.add('form-error');
+  $('.fb-form input').on('change', function() {
+    $('.el--text')[0].classList.remove('form-error');
+  });
+}
+
 function teamPasswordFormError(toosimple) {
   $('.el--text')[1].classList.add('form-error');
   if (toosimple) {
@@ -115,11 +122,16 @@ function sendIndexRequest(request_data) {
       goToPage(responseData.redirect);
     } else {
       // TODO: Make this a modal
-      verifyTeamName('register');
       if (responseData.message === 'Password too simple') {
         teamPasswordFormError(true);
       }
-      teamTokenFormError();
+      if (responseData.message === 'Login failed') {
+        teamLoginFormError();
+      }
+      if (responseData.message === 'Registration failed') {
+        teamNameFormError();
+        teamTokenFormError();
+      }
     }
   });
 }